Digital Paint Discussion Board

Development => Bugs, Feature Requests, and Feedback => Topic started by: MosEz on October 21, 2007, 04:25:30 PM

Title: 2 Flag Overtime Bug
Post by: MosEz on October 21, 2007, 04:25:30 PM
It was in the match vs CC. We were leading by 2 points. 2v1 situation. Both cc players got flag and I got also both flags. Time left. I should won or not?

Look at the screens what happened.

(http://img136.imageshack.us/img136/4538/ccjh3.jpg) (http://imageshack.us)




(http://img116.imageshack.us/img116/6997/cc2hr9.jpg) (http://imageshack.us)


Why did i only get the points for 1 flag and not for 2? And why did i only get 1 flag back and not 2?

Title: Re: Match vs CC
Post by: coLa on October 21, 2007, 05:01:00 PM
it was obviously a glitch. that sort of stuff happens. nothing is perfect. you lost. HAXORZZZ!!!
Title: Re: Match vs CC
Post by: nightryder on October 21, 2007, 05:04:24 PM
why did it got o overtime if the score was 50-37?
Title: Re: Match vs CC
Post by: b00nlander on October 21, 2007, 05:14:51 PM
they went to overtime at about 35-35, then they got some points for the flags, then Meini died and the others capped 12 points from the 2 flags.
And yes, its a bug... must have gotten into the code when jitspoe made that new overtime feature (build 13? or later?)
Title: Re: Match vs CC
Post by: godzilla on October 22, 2007, 04:06:50 AM
lol CC is pretty good...they have some good players down at CC.

how did it go overtime if the score was RED:37 BLUE:50?

you wouldve lost?
Title: Re: Match vs CC
Post by: frozi on October 22, 2007, 06:47:31 AM
its not that CC won guys. we want to know something about the fact that:
we lead 37-35 have both flags
and cc got both flags too

so why overtime normaly we should get 2 points for each flag so : 35+2+2 = 39
and cc should get 2points for each flag so:                                 33+2+2 = 37

so why overtime?
Title: Re: Match vs CC
Post by: lekky on October 22, 2007, 07:08:35 AM
To me it looks like they are posting a bug, not taking a DP match too seriously, but nice try Jigsaw. It looks like they should have won, and if they accepted defeat good luck to them because they shouldn't have after reviewing this.

Its obviously a bug like PURE said. Hopefully it can be fixed now its brought to jitspoes attention.
Title: Re: Match vs CC
Post by: frozi on October 22, 2007, 07:10:34 AM
lol its not really that point. we just want to get game-mistakes out so its more fun.
your argumentation seems to be pretty bad.
so lets just get the match out of that and think about that special case only.

thx lekky ;)
Title: Re: Match vs CC
Post by: MosEz on October 22, 2007, 08:14:28 AM
To me it looks like they are posting a bug, not taking a DP match too seriously, but nice try Jigsaw.

right.

and btw the score was 35:33 +2 points for me and + 4 points for cc makes 37:37. I got killed they caped 37:49 -> last round 37:50

Man those CC guys are good.

Did we left tiemap? Dont think so
Title: Re: Match vs CC
Post by: coLa on October 22, 2007, 12:43:57 PM
Did we left tiemap? Dont think so

what does leaving a match have anything to do with being good? congrats. we gave you a win.

ts obviously a bug like COLA said.

fixed. :P
Title: Re: Match vs CC
Post by: MosEz on October 22, 2007, 01:02:48 PM
we gave you a win.

raped on pp1 Iam sorry :/
Title: Re: Match vs CC
Post by: Playah on October 22, 2007, 02:18:13 PM
This thread (started by my suggestion to mosez) is just to show jitspoe a bug he has to resolve. The problem has been stated enough times now in this thread.

Close thread please.
Title: Re: Match vs CC
Post by: jitspoe on October 23, 2007, 10:01:43 PM
Quote
and btw the score was 35:33 +2 points for me and + 4 points for cc makes 37:37

37:37 would have been a tie, thus it went into overtime.  It's working exactly the way it should.

Edit: Misread.  I don't think the overtime code was set up to handle multiple flags on each team correctly.
Title: Re: 2 Flag Overtime Bug
Post by: bitmate on October 24, 2007, 01:44:46 PM
The point is that MosEz had 2 flags, adding 4 points to their score would result in a 39:37 final score.  ::)
Title: Re: 2 Flag Overtime Bug
Post by: b00nlander on October 24, 2007, 05:23:59 PM
its not that CC won guys. we want to know something about the fact that:
we lead 37-35 have both flags
and cc got both flags too

so why overtime normaly we should get 2 points for each flag so : 35+2+2 = 39
and cc should get 2points for each flag so:                                 33+2+2 = 37

so why overtime?

glad you figured that out by now, bitmate.
Title: Re: 2 Flag Overtime Bug
Post by: bitmate on October 25, 2007, 11:18:25 AM
glad you figured that out by now, bitmate.
Just wanted to paraphrase it for jitspoe.
Title: Re: 2 Flag Overtime Bug
Post by: Playah on October 25, 2007, 03:51:41 PM
I did, i sent a pm to him...
Title: Re: 2 Flag Overtime Bug
Post by: lekky on October 25, 2007, 07:08:36 PM
I think jitspoe got a few pm's from this thread :D
Title: Re: 2 Flag Overtime Bug
Post by: coLa on November 03, 2007, 09:59:37 PM
I THOUGHT THIS BUG WAS FIXED? IT HAPPENED AGAIN A WHILE AGO. THIS TIME TO ME. WTF IS UP YO.
Title: Re: 2 Flag Overtime Bug
Post by: Eiii on November 03, 2007, 10:00:09 PM
I THOUGHT THIS BUG WAS FIXED? IT HAPPENED AGAIN A WHILE AGO. THIS TIME TO ME. WTF IS UP YO.
Wait for a release maybe?
Title: Re: 2 Flag Overtime Bug
Post by: coLa on November 03, 2007, 10:01:23 PM
how about you come over and i can show you how a real man loves another. :P i heard it was fixed MAH BAD. anyways. we still won. =\
Title: Re: 2 Flag Overtime Bug
Post by: lekky on November 03, 2007, 10:17:36 PM
I THOUGHT THIS BUG WAS FIXED? IT HAPPENED AGAIN A WHILE AGO. THIS TIME TO ME. WTF IS UP YO.

;D
Title: Re: 2 Flag Overtime Bug
Post by: jitspoe on November 08, 2007, 02:07:38 AM
I'm confused.  I took a look at the code to see if there was a quick fix:

Code: [Select]
void CheckForBonusPoints (void)
{
edict_t *flag = NULL;
qboolean needs_overtime;

needs_overtime = GameNeedsOvertime(); // 1.831

while ((flag = G_Find(flag, FOFS(classname), ITEM_SCORE_STRING)))
{
if (flag->teamnumber == 0)
continue;

// Flag must be owned, and belong to a team with no players.
if (flag->owner && (!GetLivingPlayersOnTeam(flag->teamnumber) || (GameIsGameOver() && !needs_overtime))) // 1.831
{
{
char LOGping[256];
char LOGtime[256];
strcpy(LOGtime, va("%i", (int)level.time));
strcpy(LOGping, va("%i", (int)flag->owner->client->ping));
PrintToLog(flag->owner->client->pers.netname, NULL, "FlagBONUS", NULL, "3", LOGtime, LOGping, 1);
}

safe_bprintf(PRINT_HIGH,"%c%s's %s earned 2 points for possesion of eliminated teams flag!\n",
splat(flag->owner->teamnumber),
TeamsGetName(TeamsGetTeam(flag->owner)),
flag->owner->client->pers.netname);

flag->owner->client->resp.flagretsscore += 2;
TeamsAdjustScore(TeamsGetTeam(flag->owner), 2);

if (!GameIsRoundOver()) // 1.80 - so flag doesn't show up at round end when someone is carrying it
{
DropCtfFlags(flag->owner, flag->teamnumber); // 1.80
MakeTouchable(flag); // Only make flag appear at base if there are other teams alive
}

flag->pickuptime = level.time;
flag->nextthink = 0;
flag->think = NULL;
flag->owner = NULL;
flag->nextdo = 0;
flag->pbitem = 1; // TODO Move this to SP function

if (flag->origin1[0] != 0 || flag->origin1[1] != 0 || flag->origin1[2] != 0)
{
VectorCopy(flag->origin1, flag->s.origin);
flag->s.event = EV_OTHER_TELEPORT;
}
}
}
}

I don't see how it's possible for somebody to get credit for just 1 flag.  It loops through all the flags before anything else ever happens in the game, unless you were playing on a server with the old version before I fixed the bug (it used to have GameNeedsOvertime() in the loop, I believe).  What server was this on, and what version was it running?
Title: Re: 2 Flag Overtime Bug
Post by: Playah on November 08, 2007, 11:59:34 AM
I wasn't playing but judging from the sreenshot it must've either been a GT Match or an eR33t match. All those servers have the same (150) version.
Title: Re: 2 Flag Overtime Bug
Post by: coLa on November 08, 2007, 12:09:21 PM
it was on an er33t server. not sure what version it was but i am sure bain can tell you. this is what happened. we were down by 2 points about 30sec left, playing pbcup_pforest, i grabbed both flags and i was hiding in backdoor waiting for the time to run out thinking i was going to get credit for both flags. as soon and the time struck 0 it gave me credit for one flag and made me drop the other and went into overtime. =\
Title: Re: 2 Flag Overtime Bug
Post by: Playah on November 08, 2007, 03:48:07 PM
Not that you missunderstand me jits: I was referring to the original match "mosez" reported.
Title: Re: 2 Flag Overtime Bug
Post by: jitspoe on November 08, 2007, 03:53:39 PM
Hmm, looks like they're running the latest version.

Aha, I see what's going on now:

Code: [Select]

if (!GameIsRoundOver()) // 1.80 - so flag doesn't show up at round end when someone is carrying it
{
DropCtfFlags(flag->owner, flag->teamnumber); // 1.80
MakeTouchable(flag); // Only make flag appear at base if there are other teams alive
}

In 4-team mode, if a team is eliminated, whoever is carrying their flag is forced to drop it.  You can't capture the flag of an eliminated team.  It's just checking for round over, though, not game over.  Quick fix would be to check for game over, too, but this bug could resurface on a map with more than 2 teams and more than 1 flag per team.  I think making a function that just drops one flag would fix it.